Open Lakshmikanth2001 opened 2 years ago
This is something I've been interested in exploring. I think it would be worth investigating the value of extending Python's base complex
class as a phasor, and formulating the unique methods we need.
Overall, I'm for it! Let's explore what can be done!
I've done some exploratory work on this subject. Ultimately, I want to extend the existing functionality from Python's complex
type, because I believe it will help set a few guard rails. This work can be explored in https://github.com/engineerjoe440/ElectricPy/blob/dev/investigate-phasor-type-class/electricpy/_phasor.py
I want to acknowledge the length of work you'd gone to on this, however. You've put forth some really tremendous effort! I think if I'm to move forward to this, I'm going to use some of your docstrings, since I like them much more than my own. (mine were very short in some cases).
Please explore and let me know what your thoughts are!
I've gone ahead and built a separate Python package called phasors
that's available here: https://github.com/engineerjoe440/phasors and provides this exact functionality. I'll be looking to pull that back in for use in this package at some point in the future.
Can we replace all our
functional
code intoobjected-oriented
fashion so that it will be really intuitive for users to just add, sub, mul, eq phasor