search

engineerjoe440 / ElectricPy

Electrical Engineering Formulas in Python
https://electricpy.readthedocs.io/en/latest/
MIT License
86 stars 16 forks source link

Parallel Plate Capacitor and Solenoid Inductance #47

Closed miguelzaqui closed 2 years ago

miguelzaqui commented 2 years ago

Since previous versions, there is a function to calculate the resistance of a wire (wireresistance). As a complement, the functions for calculating the capacitance of a parallel plate capacitor (parallel_plate_capacitance) and the inductance of a solenoid (solenoid_inductance) have been added.

Lakshmikanth2001 commented 2 years ago

Thank you very much... , Please try to include test cases for your functions so that we can test your function across various input

please review test directory of our project

engineerjoe440 commented 2 years ago

I wanted to say thank you for your contributions! I greatly appreciate your interest and support. I think that there is great value in the functions which you've added. I had a few minor suggestions mostly around general formatting. I can't wait to see these added! :)

I want to say thank you, also, to @Lakshmikanth2001. He has been incredibly helpful, and has kept the project moving when I've been terribly slow. His points are valid about adding test cases. Little tests will make a big difference and will help make sure that folks like me don't accidentally break your functions as maintenance continues.

miguelzaqui commented 2 years ago

Thank you very much... , Please try to include test cases for your functions so that we can test your function across various input

please review test directory of our project

I was just implementing the tests of these functions. I confess that I am not very familiar with the subject of tests in Python, but you can review it and tell me if it meets the requirements.