engineersftw / website

Engineers.SG
https://www.engineers.sg
17 stars 15 forks source link

Show a heading for each day in the events list #36

Closed joeytwiddle closed 6 years ago

joeytwiddle commented 6 years ago

Browsing the current layout, I find it difficult to see when one day ends and the next day begins:

So I added a clear heading (and a gap) when each new day starts:

Of course this does eat up some screen space, but I think it conveys useful information.

I hope you like it. I am sorry there are so many lines of code! (I had to override some of the default CSS rules.)

joeytwiddle commented 6 years ago

Alternatively, here is a simpler design, where the headings are just text (no blue box).

Let me know if you prefer this design.

The changes for this design are:

/* Remove {padding, background-color, color} from .date-marker */

/* Add the following inside .date-marker: */
        border-bottom: 1px solid #e0e0e0;
        h5 {
            font-weight: bold;
            font-size: 1.8rem;
        }

Unfortunately I find in this design, the date heading appears too similar to the event titles, so it doesn't stand out. enough A splash of colour or a calendar icon next to the date might help to indicate something significant, as the user scrolls past. (Centering the date can work.)

joeytwiddle commented 6 years ago

I also looked into reformatting the times shown inside each event card.

### _event_with_map.html.slim

      /strong=event["formatted_time"]
      strong=Time.zone.parse(event["start_time"]).to_datetime.strftime("%-I:%0M%P") + " to " + Time.zone.parse(event["end_time"]).to_datetime.strftime("%-I:%0M%P")

I have not added this code to the PR.

Pros:

Cons:

Also: