engineyard / ey-cloud-recipes

A starter repo for custom chef recipes on EY's cloud platform. These are for reference, and do not indicate a supported status.
http://www.engineyard.com/products/cloud
Other
980 stars 291 forks source link

[Sidekiq] sidekiq::cleanup is invoked every chef run #350

Open radamanthus opened 6 years ago

radamanthus commented 6 years ago

https://github.com/engineyard/ey-cloud-recipes/blob/master/cookbooks/sidekiq/recipes/default.rb#L6

cleanup needs to run only when changing the instance(s) where sidekiq is run:

Basically, when this part of the recipe is changed: https://github.com/engineyard/ey-cloud-recipes/blob/master/cookbooks/sidekiq/recipes/setup.rb#L6

In practice this very rarely happens. For most cases, and especially on production environments, after the strategy (run on application or utility instances) has been set, cleanup should not be run.

Changes needed: