search

engineyard / eycap

Engine Yard specific capistrano recipes
117 stars 63 forks source link

Misleading comments and use of sudo method in mongrel.rb recipes #2

Open bratta opened 14 years ago

bratta commented 14 years ago

The tasks in the mongrel namespace are using the sudo method to interact with monit, but the comments allude to the fact that they can be run without sudo access by toggling :use_sudo. This is not true, however, because the sudo command always runs using sudo. The commands should most likely use the _trysudo command instead, which looks at the :use_sudo flag or if :run_method is :sudo.

This was reported by jonah_ in IRC.

jonahb commented 14 years ago

For example, see line 16 of mongrel.rb

jonahb commented 14 years ago

Aso, tasks in many namespaces, not just mongrel, call sudo. It would be nice if they all respected the use_sudo setting.

7hunderbird commented 11 years ago

Created internal ticket M-155 to track this issue.