enginkizil / FeedEk

FeedEk jQuery RSS/ATOM Feed Plugin
https://jquery-plugins.net/FeedEk/FeedEk.html
MIT License
207 stars 107 forks source link

Re-enable Atom feed parsing since move to YQL #56

Closed colmoneill closed 5 years ago

colmoneill commented 7 years ago

I believe the move to YQL with FeedEk 3.0 had Atom feeds working, but somewhere, something (probably in YQL) has changed, and the query format is different now.

Multiple issues ( #52, #53, #55, #35) point to the error created by the unassigned values on https://github.com/enginkizil/FeedEk/blob/master/js/FeedEk.js#L31

I renamed and duplicated the FeedEd function located in js/FeedEk.js to be able to parse ATOM feeds, by adjusting the YQL to parse xml. Ather assignations of the results needed to be changed throughout the variable, but I'm not certain all of them are working properly.

The chart at https://en.wikipedia.org/wiki/RSS#RSS_compared_with_Atom was used to make the assignation adjustments, but I'm having trouble conforming to keys, because in the two Atom feeds I have tested, keys are not used in similar ways. For example: http://gitlab.com/colmoneill.atom and http://github.com/colmoneill.atom bot use the title key but gitlab uses title as a string, github used title as a dict with a type object. This is examplified by f583f646043dbbb7a752da624f40239e323a6f36.

I'm looking for ways and help to deal with these different renderings, but maybe there are enough people here already to work on this.

Thanks for any help, all the best,

enginkizil commented 5 years ago

Hello, FeedEk v3.1.0 released and YQL API is not using anymore. FeedEk can both parse RSS and Atom feeds. @colmoneill I just tested your atom url on FeedEk demo page and feeds are generated successfully.