codepathreview
commented
9 years ago :+1: Looks great overall. Good work on implementing so many optionals, the app looks polished as well.
- Great work on organizing source code.
- Nice to see you used action bar for searching
- Good job on getting the Share functionality working
- Great job implementing FilterDialogFragment for filters.
- Good job using the ConnectivityManager to check for network availability
- You should have a single base method in search activity to fetch results for both initial load and the pagination, currently you have two different methods.
- Some JSON parsing logic is implemented as part of activity, it should be part of model.
- Great job using staggered grid view for polishing the app UI.
- Great job on getting panning and zooming work
- Consider using Parcelable instead of Serializable(benefits)
I have provided a detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be very important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
My app is ready for review. /cc @codepathreview @codepath.
Thanks, -Andrew