use Buffer until last moment to avoid byte-length issues for garbage dat...

englercj / node-esl

FreeSWITCH ESL implementation for Node.js; implements the full Event Socket Library specified in: http://wiki.freeswitch.org/wiki/Esl

http://englercj.github.com/node-esl/

MIT License

171 stars 109 forks source link

use Buffer until last moment to avoid byte-length issues for garbage dat... #16

Closed cxreg closed 10 years ago

cxreg commented 11 years ago

Avoid interpreting wire data as utf-8 as long as possible to avoid misunderstandings about the length of the received data

cxreg commented 11 years ago

Any comments on this PR?

englercj commented 11 years ago

I think it looks good, I haven't had a second to run my own tests and merge it in. Hopefully I should be able to soon. Thanks a lot for looking into this and submitting this PR!