englercj / node-esl

FreeSWITCH ESL implementation for Node.js; implements the full Event Socket Library specified in: http://wiki.freeswitch.org/wiki/Esl
http://englercj.github.com/node-esl/
MIT License
170 stars 111 forks source link

Authentication failure is not reported to user. #37

Closed icecubed closed 10 years ago

icecubed commented 10 years ago

When FSW authentication fails after connection there is no feedback sent back to the user. I have a fix here https://github.com/icecubed/node-esl/commit/67d3165dc5015fe5653add95800984ca59eaa365

Does that look feasible. If so I can initiate a pull request

englercj commented 10 years ago

Not sure what you mean, the ''esl::event::auth::fail' event tells the user that authentication failed. Is that not enough?

icecubed commented 10 years ago

Yes it is enough. The error I was observing was due to the typo in the disconnect notice case statement. Thanks for the help