search

englercj / node-esl

FreeSWITCH ESL implementation for Node.js; implements the full Event Socket Library specified in: http://wiki.freeswitch.org/wiki/Esl
http://englercj.github.com/node-esl/
MIT License
170 stars 111 forks source link

Issue #84 -- emit esl::end on socket::close #87

Open ssinyagin opened 4 years ago

ssinyagin commented 4 years ago

net.Socket emits "end" only on successful closing, but it emits "close" in error conditions as well.

englercj commented 4 years ago

If you rebase this branch to the latest, it should run CI so we can check if it passes.

david-goncalves commented 4 years ago

We think we are facing the same issue. The TCP connection was closed and the application does not receive any signal. Can we do something to help fixing the problem?

englercj commented 3 years ago

A PR on the latest v1 branch with these changes that pass CI would allow me to merge it in.

ssinyagin commented 3 years ago

come on, it's a one-liner patch, and you have the PR in two branches already

ssinyagin commented 3 years ago

and this PR is actually against v1.x branch

blerest commented 2 years ago

Hello @englercj, does it possible to merge this PR?