englercj / resource-loader

A middleware-style generic resource loader built with web games in mind.
http://englercj.github.io/resource-loader/
MIT License
424 stars 77 forks source link

Added function overloading JSDoc for `add` function #126

Closed goldenratio closed 5 years ago

goldenratio commented 5 years ago

Hi,

@englercj please check

out of topic: Class<T> For me Class<async> doesn't generate typeof async. I think you need to make new release for https://github.com/englercj/tsd-jsdoc

englercj commented 5 years ago

For me Class doesn't generate typeof async. I think you need to make new release for

I do, I used my local version to generate the typings.

englercj commented 5 years ago

Went ahead and added this to master because I had a few minutes before work. Thanks for helping me figure this out!

goldenratio commented 5 years ago

@englercj Thanks. Any plans for MiniSignal types? :D

englercj commented 5 years ago

Just pushed something to master, give that a try.

goldenratio commented 5 years ago

looks good. If any issues, I will let you know... Thanks a lot. Happy holidays!

englercj commented 5 years ago

Same to you!