englercj / tsd-jsdoc

Compiles JSDoc annotated JavaScript into a Typescript Definition file (.d.ts)
MIT License
315 stars 42 forks source link

`@template` doesn't work with JSDoc 3.6 #86

Open lemnis opened 5 years ago

lemnis commented 5 years ago

Input:

/**
 * @name foo
 * @constructor
 * @template T
 */

Result:

/**
 * @name foo
 * @constructor
 * @template T
 */
declare class foo {
}

Expected:

/**
 * @name foo
 * @constructor
 * @template T
 */
declare class foo<T> {
}

I don't know if other tags stopped working...

englercj commented 5 years ago

I haven't actually tried jsdoc 3.6 yet, but looks like they added support for closure compiler tags which means they won't show up in the "unknown tags" section anymore.

samparsky commented 5 years ago

@englercj how much work is required to support jsdoc 3.6.x?

englercj commented 5 years ago

No idea, haven't looked. Feel free to give it a shot and submit a PR.