Python Embedding - Githubissues

engraftdev / engraft

https://engraft.dev

MIT License

36 stars 0 forks source link

Python Embedding #3

Closed tfsingh closed 1 year ago

tfsingh commented 1 year ago

Hi Josh, here's the initial code for the Python embedding -- I think my prettier might have made some stylistic changes, please let me know if you'd like me to switch them back!

tfsingh commented 1 year ago

@joshuahhh pr should be much cleaner for your review!

tfsingh commented 1 year ago

Okay, this should be ready for another round of review! I left the files I renamed to preserve your comments, but just let me know when and I can push deletions anytime :)

joshuahhh commented 1 year ago

Thanks for addressing all my little bits & bobs!

Feel free to delete the old files.
Let's get the engraft-on-PATH thing working for you before we check this in!
I'm kinda chewing on where exactly this project belongs in the monorepo. Give me a bit of time to chew on that.

tfsingh commented 1 year ago

Okay, pr should be in good shape -- please let me know what you think!

joshuahhh commented 1 year ago

Great work!