search

engyon / enprot

enprot command line tool for Engyon
1 stars 1 forks source link

ci: Add GitHub Releases #42

Closed dewyatt closed 4 years ago

dewyatt commented 4 years ago

This took a while to get right because of various issues but ultimately ended up being fairly small.

I gave up on adding an MSVC target after burning time on an incompatibility between git and powershell, but I have a workaround in hand and will create an issue to follow up on that.

codecov[bot] commented 4 years ago

Codecov Report

Merging #42 into master will increase coverage by 0.18%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   66.57%   66.75%   +0.18%     
==========================================
  Files           8        8              
  Lines        1110     1110              
  Branches      248      248              
==========================================
+ Hits          739      741       +2     
  Misses        161      161              
+ Partials      210      208       -2
Impacted Files Coverage Δ
src/lib.rs 75.4% <ø> (ø) :arrow_up:
src/pbkdf.rs 72.05% <0%> (+1.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d552a6d...82a3ce3. Read the comment docs.

ronaldtse commented 4 years ago

@dewyatt this is comprehensive! I see that Enprot is soon merging into the problem of using managed keys... 😉 Merging.

dewyatt commented 4 years ago

Thanks @ronaldtse this took way more work than expected. I still need to do the crate publishing. I went ahead and bumped the version to 0.2.0 since we have come a long way since 0.1.0, and CI functioned as planned: https://github.com/riboseinc/enprot/releases/tag/0.2.0

ronaldtse commented 4 years ago

Two releases with a version bump in a day. Woohoo! 👍 This https://github.com/tower-rs/tower/pull/407 looks like a viable workflow for publishing crates...