Check code format correctness in Travis CI

engyon / enprot

enprot command line tool for Engyon

1 stars 1 forks source link

Check code format correctness in Travis CI #9

Closed skalee closed 5 years ago

skalee commented 5 years ago

As of PR #6, the Rust code is formatted with Rustfmt tool. Let's add Rustfmt checks in Travis CI to ensure that code format correctness is not violated.

ronaldtse commented 5 years ago

@skalee thanks, while you're at it, could you help migrate this to GitHub Actions? It's a lot faster for tests. We've been migrating all our other projects too!

skalee commented 5 years ago

Yes, probably. I don't know how they work though. I got to do some research.

ronaldtse commented 5 years ago

@skalee It allows running of Ubuntu, macOS and Windows. It also allows running Docker containers.

Sample for 3 platforms: https://github.com/metanorma/metanorma-csand/pull/18
Sample for Docker container: https://github.com/metanorma/mn-samples-iso/blob/master/.github/workflows/publish.yml

skalee commented 5 years ago

@ronaldtse Does it mean that unit tests should be migrated from Travis to GH Actions as well?

ronaldtse commented 5 years ago

@skalee yes, we're going to abandon Travis. It was one of @dewyatt 's dreams.

skalee commented 5 years ago

I'm not astonished. Using Docker in Travis is quite unpleasant.

Opened a new issue #10.

skalee commented 5 years ago

Closing. It was re-implemented in #12.