enhance-dev / enhance-ssr

Server side render for custom elements.
143 stars 9 forks source link

Adds enhanced ✨ attribute so we know when to replace children in our … #52

Closed kristoferjoseph closed 1 year ago

kristoferjoseph commented 1 year ago

Brian ran into an issue when using our Custom Element base class for strictly client side purposes. We currently don't expand your Custom Element with the template contents if it has children already since we assume it's been SSR'd. In this case it had authored children to be replaced but we didn't expand it since this is only in the browser. The only sure fire way I could come up with to know for sure that we expanded the custom element server side is to add an attribute enhanced.

This has a boolean that allows you to omit this if you don't want it, but I think people will.

This also sneaks in looking for a render function on the prototype of an element passed to Enhance SSR for the class only version of SSR.