search

enisdenjo / graphql-yoga-nestjs

Nest GraphQL GraphQL Yoga driver
https://the-guild.dev/graphql/yoga-server/docs/integrations/integration-with-nestjs
25 stars 11 forks source link

feat: upgrade dependancies and be compatible with Nest.js v9 #40

Closed Tchoupinax closed 1 year ago

Tchoupinax commented 2 years ago

Hello,

This PR resolves the issue with Nest.js v9, with express.

Closes here: https://github.com/charlypoly/graphql-yoga-nestjs/issues/38

TODO

charlypoly commented 1 year ago

Hi @Tchoupinax,

Thank you very much for your help on this!

Have you run the test suite locally? 👀

I would suggest that you do a first PR for Nest 19 support and another one for the Yoga 3 upgrade. Yoga 3 introduces a lot of breaking changes that need fixes in the current Driver implementation 👀

Urigo commented 1 year ago

@Tchoupinax how can we help you get this over the finish line? If you want we can also do a pair programming session, we really like to help you finish this Thank you!

Tchoupinax commented 1 year ago

Hello, I will try to find time to make test passing. :)

charlypoly commented 1 year ago

Hi @Tchoupinax,

That's awesome, thanks!

Please know that we just merged a big PR that brings support for Yoga 3. Let us know if you need help rebasing this PR 👀

Cheers!