search

enix / helm-charts

A collection of Helm packages brought to you by Enix Monkeys :monkey_face:
https://charts.enix.io
Apache License 2.0
56 stars 19 forks source link

x509-certificate-exporter: improve sensible defaults for resources #54

Closed npdgm closed 3 years ago

npdgm commented 3 years ago

Defaults for resources requests and limits may not be adequate especially with the Secrets exporter Pod. On a modest cluster I've seen cases of OOM killing happening from time to time.

A Guaranteed class with too much requested memory doesn't look like a good sensible default, it should be up to users to decide if Burstable resources on an exporter are not good enough. However I'm bumping the memory limit as it seems inadequate.

@arcln is there a way to better tune our default resources, perhaps a rule of thumb formula for how many Secrets are being scanned? I don't know if we're O(1) or O(n) with Kubernetes resources.

npdgm commented 3 years ago

We stick with the memory limit increase for now. Profiling showed usage spikes that could be caused by libraries. There is no memory leak.