search

enix / helm-charts

A collection of Helm packages brought to you by Enix Monkeys :monkey_face:
https://charts.enix.io
Apache License 2.0
56 stars 19 forks source link

Add default values for bgp peers passwords & ports #67

Closed donch closed 2 years ago

donch commented 3 years ago

Hi,

It could be cool to specify or not bgp peer passwords and port. We can put a default value if they are not provided. If we don't specify theses values, kube-router refuse to start.

gclawes commented 2 years ago

On a related note, the values.yaml examples show the port key as bgpPort, but the templates expect port: https://github.com/enix/helm-charts/blob/master/charts/kube-router/values.yaml#L123

    # kubeRouter.router.peers -- List of external BGP peers, see values.yaml for example
    peers: []
    # - ip: "1.2.3.4"
    #    asn: 65000
    #    password: ""
    #    bgpPort: 179

https://github.com/enix/helm-charts/blob/master/charts/kube-router/templates/daemonset.yaml#L57

         - "--peer-router-ports={{ range $i, $peer := .peers }}{{ if not (eq $i 0) }},{{ end }}{{ $peer.port }}{{ end }}"
npdgm commented 2 years ago

On a related note, the values.yaml examples show the port key as bgpPort, but the templates expect port

It was fixed months ago in branch next/kube-router but never got merged :( I'll make sure it lands on the next release Thanks

npdgm commented 2 years ago

@donch @gclawes, fixed and released in chart version 1.6.0 Thanks for reporting this, settings are now optional where appropriate with sensible defaults and human friendly error messages. Cheers :rocket: