search

enjalot / Inlet

Bret Victor inspired slider & color picker plugin for CodeMirror
http://enjalot.github.com/Inlet
Other
74 stars 11 forks source link

Does Not Work on Touch Devices #29

Closed michaelsboost closed 8 years ago

michaelsboost commented 8 years ago

The color picker and numeric slider were not designed for mobile support.

Some people may still want to use the Thistle color picker. So I forked the project using the Color Picker JSColor instead, because I needed touch support.

You can view the fork at https://github.com/mikethedj4/Inlet if interested.

curran commented 8 years ago

This is awesome! Great work.

curran commented 8 years ago

I also prefer the JSColor UI. and on many occasions I experienced a bug in the Thistle color picker where if the lightness is 0 (black), the dot cannot be dragged out of the center. My only concern though is the restrictive JSColor Licensing. It looks like the author is charging $25 for a non GPL licensed version, and if you use the GPL licensed version, you may not use it in commercial code.

You may want to have a look at https://github.com/bgrins/spectrum . This is released under what looks like the MIT license, and also has mobile support.

michaelsboost commented 8 years ago

I dislike Spectrum. I'm currently working on integrating JQuery MiniColors into Inlet. (Haven't figured out how to pass RGBA and HSLA into Inlet yet)

enjalot commented 8 years ago

Thanks for working towards this! what do you mean by "pass into" in this case? hsla should be supported via this regex https://github.com/enjalot/Inlet/blob/master/src/inlet.js#L343 but rgb needs to have it's regex improved to support rgba still.

is there a reason you closed this if you are still working on it?

michaelsboost commented 8 years ago

I closed because the main objective was completed (thus porting a touch friendly color picker). Getting alpha transparency to work is a separate issue.