enjalot / blockbuilder-search

API endpoint and UI for blockbuilder search page
20 stars 6 forks source link

search elasticsearch for only that contain specified filenames #29

Open micahstubbs opened 6 years ago

micahstubbs commented 6 years ago

inspired by #5

micahstubbs commented 6 years ago

working on this branch, advice is welcome https://github.com/micahstubbs/blockbuilder-search/tree/29-elasticsearch-only-thumbnails

micahstubbs commented 6 years ago

blocker: need Elastic sense app to easily new queries that would filter by the presence of a thumbnail.png file. it's hard to get sense installed and running with the old version of Elasticsearch 2.3.4 that we care currently using

micahstubbs commented 6 years ago

start point for the query, paste this into the Kibana 5.6.2 dev tools query tool

GET _search
{
  "query": {
    "wildcard": {
      "filenames": "thumbnail.png"
    }
  }
}
curran commented 5 years ago

IMO the client-side post filtering works well enough.

It would be great, though, if the thumbnail inclusion flag could be part of the URL, so that you could share links to results pages that only include thumbnails.

micahstubbs commented 5 years ago

good ideas from @nbremer and @monfera about improving our search and filtering

https://twitter.com/NadiehBremer/status/1039100202865582081

screen shot 2018-09-10 at 9 29 58 pm

micahstubbs commented 5 years ago

thumbnail.png is one kind of filename that we track, but there are others. I think it makes sense for this to generalize here.

how we represent this in the searchbar UI is a different design question. for a small number of fixed filenames, I think the checkbox approach is nice. for larger numbers of unique filenames, we probably need a design that uses a different input element.