search

enjalot / blockbuilder-search

API endpoint and UI for blockbuilder search page
20 stars 6 forks source link

[Developer Experience] Automate Local Environment Setup #74

Open hydrosquall opened 5 years ago

hydrosquall commented 5 years ago

As a developer, I would like to be able to get everything running with one command, like make run or something similar. This way, the Node app, Redis service, Mongo service, could all be launched in 1 go. The advantage is that it takes less time and effort for new developers to run the whole system, increasing the number of people who can contribute.

I'm filing this issue to gauge interest / check if there's been prior work to set up the blockbuilder stack using something like docker-compose.

I imagine this ticket would entail converting the instructions on the wiki page into a docker-compose file, and then possibly adding a Makefile to the project.

micahstubbs commented 5 years ago

yea, this is a great idea. containerizing things would make deployment easier too.

curran commented 5 years ago

I'd appreciate this as well.

hydrosquall commented 5 years ago

@micahstubbs I've started to look into this just to see how local setup works, and there are quite a few independent pieces that could go into this. The more I look at it, the more unsure I am about whether it makes sense to make a Dockerfile just for blockbuilder-search, or if it should go over into the home blockbuilder repository.

How would we feel about having some fixture gists so someone can start developing without having to scrape real data? If we like that idea, which repository feels like the natural home to put the fixture data?

micahstubbs commented 5 years ago

@hydrosquall I think a Dockerfile for blockbuilder + blockbuiler-search together in the https://github.com/enjalot/blockbuilder repo is the right path.

a separate Dockerfile for the search index in Elasticsearch that we build with the scripts in blockbuilder-search-index would also be a nice area for future work

micahstubbs commented 5 years ago

@hydrosquall I think that this is the best place for fixture data / sample data https://github.com/enjalot/blockbuilder-search-index/tree/master/data

that said, not sure if putting the fixture data in a different repo from the Dockerfile is too much indirection (looks organized to me, might look confusing to a new contributor...)