Closed curran closed 5 years ago
thanks for reporting this @curran
it looks like we need to pass an https
redirect_uri
to github during the oauth dance for https
sessions.
related to #225 - if we redirect http to https, then I think we could just always use the https uri as the redirect_uri
Happened too - can't login.
hoping to have some bandwidth to fix this one soon.
Ok, I've updated the redirect link on the github app to use https. We should probably deploy the redirect to https @micahstubbs
Still getting the Authentication error. Yikes : ((
Congrats, by the way for the app
@eduardosuela did you try loading blockbuilder with https:// instead of http:// ?
@enjalot ack, will deploy the redirect to https this weekend. related issue for that https://github.com/enjalot/blockbuilder/issues/225
@aurelient it works fine in https
@aurelient awesome thank you - that also worked for me
Sadly, I wasn't quick enough to think to check here last night when I couldn't access my block but then I remembered in the morning primed with coffee. I really appreciate all the work you've done - It's one of my favourite sandboxes!
with errors like this, it might be nice to consider adding a common error screen which captures the error message that @curran shared as well as mentioning places to visit for advice like checking github issues. The home page could also benefit from a section like:
If you encounter any problems, please check our Github issues page and report the issue if it doesn't already exist.
I like the idea of better error handling, and perhaps a FAQ entry too 💡
ok redirecting http to https is fixed 🎉 https://github.com/enjalot/blockbuilder/issues/225
not quite out of the woods on this one though. @enjalot when I click login
, I see this error:
AuthorizationError: The redirect_uri MUST match the registered callback URL for this application.
at Strategy.OAuth2Strategy.authenticate (/home/ubuntu/blockbuilder/node_modules/passport-github/node_modules/passport-oauth2/lib/strategy.js:131:25)
at attempt (/home/ubuntu/blockbuilder/node_modules/passport/lib/middleware/authenticate.js:348:16)
at authenticate (/home/ubuntu/blockbuilder/node_modules/passport/lib/middleware/authenticate.js:349:7)
at Layer.handle [as handle_request] (/home/ubuntu/blockbuilder/node_modules/express/lib/router/layer.js:95:5)
at next (/home/ubuntu/blockbuilder/node_modules/express/lib/router/route.js:131:13)
at Route.dispatch (/home/ubuntu/blockbuilder/node_modules/express/lib/router/route.js:112:3)
at Layer.handle [as handle_request] (/home/ubuntu/blockbuilder/node_modules/express/lib/router/layer.js:95:5)
at /home/ubuntu/blockbuilder/node_modules/express/lib/router/index.js:277:22
at Function.process_params (/home/ubuntu/blockbuilder/node_modules/express/lib/router/index.js:330:12)
at next (/home/ubuntu/blockbuilder/node_modules/express/lib/router/index.js:271:10)
@enjalot curious, can you check/update the redirect link on the github app one more time?
weird, in an incognito tab, the redirect link seems to work fine. I see the github login page 🤔
but then when I try to login, after I submit my github credentials it fails with the same AuthorizationError: The redirect_uri MUST match the registered callback URL for this application.
I got the error when I logged out and logged in again. I'm wondering if we need to provide the full URI for the callbackURL here: https://github.com/enjalot/blockbuilder/blob/09425c84e918c298909bcabd51bb9d9b0f88c0a9/server.js#L148 so perhaps it should be "https://blockbuilder.org/auth/github/callback" instead of "/auth/github/callback"
This should work now, please confirm
I am now able to log in with github on mobile Chrome. nice work @enjalot!
will close this one as fixed, and re-open if @curran @Fil or others report problems logging in later.
Something seems fishy about the auth flow at the moment.
Isolated this to
https
only. Authentication works fine withhttp
, gives this error withhttps
.will add the bug report from @EE2dev as well - @micahstubbs
I love to use blockbuilder and for me logging in through the github account works perfectly fine. A friend of mine wanted to host a d3.js quiz I wrote, so I thought the easiest is
Logging on github works fine. But logging on blockbuilder.org through the github account leads to the following error:
Do you need more than a github account to use blockbuilder and fork an existing gist? Do you need to have an existing github repo or a gist,..?!