Closed hydrosquall closed 5 years ago
oh very nice. will try this out locally and add a review when I do.
very nice, looks good to me 👍
Great! I was thinking of accompanying this change with an update to the wiki setup instructions for local development or in the readme for this project directly - what do you think?
On Mon, May 27, 2019 at 3:44 AM Micah Stubbs notifications@github.com wrote:
Merged #232 https://github.com/enjalot/blockbuilder/pull/232 into master.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/enjalot/blockbuilder/pull/232?email_source=notifications&email_token=ACE2MMZ3FR2W2WL6QV4WJDDPXOGMFA5CNFSM4HMIXAAKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORUW5NDA#event-2368591500, or mute the thread https://github.com/notifications/unsubscribe-auth/ACE2MM3MO6ERRMG7BMBJGT3PXOGMFANCNFSM4HMIXAAA .
@hydrosquall yes, please document it somehow. let me look, but I think that the wiki is the right place for this repo
history: @enjalot prefers docs in the wiki, @micahstubbs prefers docs in markdown files under version control. because of this history, different repos in the blockbuilder-verse have docs in different places.
ok @hydrosquall please do add a section here that describes how to optionally run redis and mongodb in a docker container https://github.com/enjalot/blockbuilder/wiki/Development#setting-up-databases
This PR adds a docker-compose script that can run Redis and MongoDb inside a docker container, for more convenient local development.
This is my first pass at https://github.com/enjalot/blockbuilder-search/issues/74 .
How to Test
docker-compose
anddocker
.Then, clone
blockbuilder
and perform the basic setup.The application will be available on
localhost:8889
!Process Notes
I tried setting up a custom bridge network using the docker docs, passing in a custom
redis.conf
to bind redis to all ports instead of justlocalhost
, and linking the services using thelink
key in docker-compose, with no luck - the mongo_client code is unable to bind to redis. I'm not sure why yet. I do know redis was running correctly because I could still connect to it viaredis-commander
.Happily, this seems to work just fine running the node server on your laptop directly, so this docker compose setup already is preferable to me manually spinning up mongo and redis.
I realized in working this that I suspect that running all this on a local machine is unnecessary if someone wants to just make frontend changes, so I am going to try to come up with an alternate workflow specifically for hacking on the
blockbuilder-search
page.