enjalot / blockbuilder

Create, fork and edit d3.js code snippets for use with bl.ocks.org right in the browser, no terminal required.
Other
323 stars 59 forks source link

[developer experience] Add docker-compose file for simpler local development #232

Closed hydrosquall closed 5 years ago

hydrosquall commented 5 years ago

This PR adds a docker-compose script that can run Redis and MongoDb inside a docker container, for more convenient local development.

This is my first pass at https://github.com/enjalot/blockbuilder-search/issues/74 .

How to Test

   brew cask install docker

Then, clone blockbuilder and perform the basic setup.

# Terminal
yarn
yarn buildWatch

# Terminal 2
docker-compose up 
# When done, remove networks with with docker-compose down

# Terminal 3
node server.js

The application will be available on localhost:8889!

Process Notes

micahstubbs commented 5 years ago

oh very nice. will try this out locally and add a review when I do.

micahstubbs commented 5 years ago

very nice, looks good to me 👍

hydrosquall commented 5 years ago

Great! I was thinking of accompanying this change with an update to the wiki setup instructions for local development or in the readme for this project directly - what do you think?

On Mon, May 27, 2019 at 3:44 AM Micah Stubbs notifications@github.com wrote:

Merged #232 https://github.com/enjalot/blockbuilder/pull/232 into master.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/enjalot/blockbuilder/pull/232?email_source=notifications&email_token=ACE2MMZ3FR2W2WL6QV4WJDDPXOGMFA5CNFSM4HMIXAAKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORUW5NDA#event-2368591500, or mute the thread https://github.com/notifications/unsubscribe-auth/ACE2MM3MO6ERRMG7BMBJGT3PXOGMFANCNFSM4HMIXAAA .

micahstubbs commented 5 years ago

@hydrosquall yes, please document it somehow. let me look, but I think that the wiki is the right place for this repo

history: @enjalot prefers docs in the wiki, @micahstubbs prefers docs in markdown files under version control. because of this history, different repos in the blockbuilder-verse have docs in different places.

micahstubbs commented 5 years ago

ok @hydrosquall please do add a section here that describes how to optionally run redis and mongodb in a docker container https://github.com/enjalot/blockbuilder/wiki/Development#setting-up-databases