enjalot / tributary

rapid prototyping with d3.js
http://tributary.io
Other
598 stars 71 forks source link

User/[username]/latest is no longer returning visit count #127

Open gelicia opened 9 years ago

gelicia commented 9 years ago

See http://tributary.io/api/user/gelicia/latest/100/0 The last time it returned a visit count is May 28th.

Good news is, recording visits still works http://tributary.io/api/latest/visits

It's just not aggregating them for the user API call anymore. I'll try to look into this but maybe someone can beat me to it :)

This affects the user page and, consequently, my self esteem (just kidding)

enjalot commented 9 years ago

If you want to look into it, I know the cause of the problem but I don't know the complete solution.

When I aggregate view counts I ignore all gist ids that look like the long hash (instead of the numbers) to avoid returning stats on private gists. recently github changed all the ids to look like the hashes, so its no longer a good way to separate them. What should really happen is that there should be a "private" property on the visits of private gists and we should skip them in the aggregation.

would love it if you dug in, let me know if you need help!