enjalot / tributary

rapid prototyping with d3.js
http://tributary.io
Other
598 stars 71 forks source link

Fix in start.js for make failure: cannot find module 'CodeMirror' #128

Closed eldrgeek closed 9 years ago

eldrgeek commented 9 years ago

There are two problems found in installation.

  1. The make fails (fixed by this commit)
  2. Three versions of handlebars in package.js: two in dependencies, one in devdependencies I have fixed the former problem which is fatal but not the latter.

Fix is to change "CodeMirror" to "codemirror"

Note that the other files that I have committed are there because make updates them.

I think this makes it harder for you to review the change.

Since all of the static files are created by the make perhaps we should add static to .gitignore and remove the static files from the checkout

enjalot commented 9 years ago

thanks so much for getting to the bottom of this!