search

enjalot / tributary

rapid prototyping with d3.js
http://tributary.io
Other
598 stars 70 forks source link

editor freezes #85

Closed aeosynth closed 9 years ago

aeosynth commented 11 years ago

not always, but sometimes when i press cmd+delete (delete to beginning of line), the editor freezes (unresponsive, 100% cpu usage)

edit: osx 10.7.5, chrome 25

georules commented 10 years ago

I thought I would look into this. What is providing you delete to beginning of line via cmd+delete? I don't get that functionality at all in the version of codemirror used on tributary.io right now.

aeosynth commented 10 years ago

i assume either osx or chrome provides the cmd+delete functionality

when i create a new 'inlet', i can type 'foo bar baz', and delete it with cmd+delete. curiously, if i open the example, or copy and paste some of its code into a new inlet, i do not have that functionality

georules commented 10 years ago

Very strange, I do not get cmd+delete in either a new inlet or an example/someone else's. Also osx/chrome. I'll keep trying to investigate this.

ejfox commented 10 years ago

I replicated it on 10.8.5 / Chrome 31. CMD-delete deletes the entire line in a new blank Tributary, but if I load up the example it doesn't work. If I copy the code from the example into a blank new inlet (without saving) CMD-delete also stops working. If you remove the code and write nonsense and command delete, it works again.

CodeMirror could possibly be hijacking command delete, and perhaps we could have code mirror ignore the command key http://codemirror.net/doc/manual.html#event_dom

Here's a CodeMirror PR for CMD+Delete that suggest CodeMirror itself doesn't support cmd-delete.