search

enjarai / blahaj-of-undying

Soft toy, shark mod, 16px, client-side.
https://modrinth.com/mod/blahaj-of-undying
The Unlicense
15 stars 5 forks source link

Change the orientation and scale of the plushies when placed in item frames #9

Closed ODF4 closed 1 month ago

ODF4 commented 2 months ago

I just thought of this idea for the mod, but I want to preface this by saying that I'm not sure if this can be implemented without affecting the orientation of the models when held by the player.

I think it could be really cool if you could put plushies inside item frames placed on top of blocks to use them as decoration. This would be similar to how some custom item texture resource packs work, such as Mizuno's 16 Craft CIT PACK or ItemBound: Rebound. I also think that the plushies placed in item frames should be bigger than they currently are, so that they are the same size as when held by the player.

item frames

Crephan commented 1 month ago

So the reason they currently look like this in item frames is due to the fact the majority of players hang item frames on walls. In vanilla Minecraft custom models only support a single local orientation for item frames. Rai said she could possibly implement your suggestion for plushies added by the mod itself, but that it would be hard.

Also, the reason plushies aren't that big in item frames is because if they were huge, they would start clipping into other blocks. If you want your blahaj to be larger inside an item frame, then just use the large variant of the plush.

ODF4 commented 1 month ago

So the reason they currently look like this in item frames is due to the fact the majority of players hang item frames on walls. In vanilla Minecraft custom models only support a single local orientation for item frames. Rai said she could possibly implement your suggestion for plushies added by the mod itself, but that it would be hard.

It would makes sense to keep things the way they are now, especially if other people already put the plushies in item frames as you described. And yeah I thought this might be complex to implement so don't worry about it at all!

Also, the reason plushies aren't that big in item frames is because if they were huge, they would start clipping into other blocks. If you want your blahaj to be larger inside an item frame, then just use the large variant of the plush.

And I completely forgot about the "large" variants, so thank you for reminding me!

I guess we can close the issue then? Feel free to do so!

Crephan commented 1 month ago

Maybe. It depends on if @enjarai still wants to go out of her way to do something about it or not. :)

enjarai commented 1 month ago

I think this is out of scope for now, so I'll close this issue. I may look into it in the future if I find the time...

ODF4 commented 1 month ago

I think this is out of scope for now, so I'll close this issue. I may look into it in the future if I find the time...

Not a problem at all, don't worry about it!