enjarai / do-a-barrel-roll

Microsoft flight simulator for Minecraft elytras.
https://www.curseforge.com/minecraft/mc-mods/do-a-barrel-roll
GNU General Public License v3.0
94 stars 29 forks source link

With Vic's Point Blank Mod installed, the camera does not rotate left or right when flying with an elytra. #160

Open byxea opened 4 months ago

byxea commented 4 months ago

Describe the issue When Vic's Point Blank mod is installed alongside Do a barrel roll, the camera does not rotate left or right when flying with an elytra.

Crash report/logs (if applicable) https://mclo.gs/ZtUDCiH

Screenshots image ^ Flying upside down, camera doesn't rotate

image ^ Flying sideways, again camera doesn't rotate

image ^ Intended camera rotation when flying upside down with Vic's Point Blank not installed.

image ^ Intended camera rotation when flying sideways

MC version: 1.21

Mods

enjarai commented 4 months ago

Point Blank is probably redirecting a specific method call that DABR modifies in its own way to make rolling work. I cant be sure of this though, since Point Blank seems to be closed source. This means a fix will probably have to come from their side. :/

hologarden commented 4 months ago

also having this problem with vic's point blank installed, same config as @byxea

enjarai commented 4 months ago

I've looked into the issue, and its most likely a conflict with DABR's mixin here: https://github.com/enjarai/do-a-barrel-roll/blob/arch/1.21/common/src/main/java/nl/enjarai/doabarrelroll/mixin/client/roll/CameraMixin.java

The main issue stands though. Because Point Blank is closed source, I have no idea what they're doing to break this. For a fix to happen, the author of VPB will have to either implement a fix themselves, or contact me with more details on the exact nature of their mixin. I'd be happy to implement a compatibility patch if I know what the underlying cause of the issue is.

Twister1M commented 3 months ago

I'm having a similar issue in the modpack Prominence II RPG, but I do not have the above mod as part of it: https://www.curseforge.com/minecraft/modpacks/prominence-2-rpg

This makes me think it isn't mod specific but some other issue multiple different mods could have.

For me, the vertical camera rotation works but not the rolling camera (I can do loops with the camera, but not rolls). What's interesting is that it worked the first time I used the elytra, but after logging off for the night, when I came back I had the same issue as above. To note, only I have the issue, so there seems to be some inconsistencies about the problem in multiplayer.

RichBrinky commented 3 months ago

Just encountered the same problem as @Twister1M, worked like a charm on a server hosted by a friend for a while, then during this day it stopped working, Might be hitting a specific keybind in the modpack or going to a singleplayer world halfway thorugh the day maybe?