enjarai / recursive-resources

Minecraft mod that enhances the Resource Pack menu with folder support.
Mozilla Public License 2.0
20 stars 8 forks source link

Resource packs with the same name are displayed only in one place #16

Closed Felix14-v2 closed 1 year ago

Felix14-v2 commented 1 year ago

I will try to catch this bug and find a conflicting mod, but it doesn't look like there is any way to reproduce it, this bug always appears randomly (I hate "floating" bugs)

https://user-images.githubusercontent.com/75726196/228940734-56f8106f-8188-4146-a301-12129390a738.mp4

latest.log

UPD: Minecraft no longer sees this resource pack 0_0 Переводы всего.zip

enjarai commented 1 year ago

Can you try to send a log that captures the moment a pack dissapears? It might not, but if it contains a clear error I'll at least have something to go on.

Felix14-v2 commented 1 year ago

captures the moment a pack dissapears?

The log above was recorded at this moment, I even caused a diagnostic crash so as not to lose it. And yeah, I can confirm, that this pack now disappears with your mod and works fine without it.

enjarai commented 1 year ago

Ah my bad, didn't notice the attached log. There seem to be a lot of errors about an invalid CEN header, but nothing that'd explain this odd behaviour.

The strangest part is that my mod changes nothing about pack loading itself, it just tells MC to do more of it, so I'm not sure what could be going wrong. I'll see if I can replicate it on my machine when I have time.

Felix14-v2 commented 1 year ago

Thanks! In the worst case scenario, I will send you my entire Minecraft instance.

Felix14-v2 commented 1 year ago

I think I've caught it! Previous version of this pack also exists in subfolder, and Recursive resources don't understand, that this is a second pack with the same name, but different logo and content: image Idk how I missed that, but pack on the video – is an old version with a placeholder logo and old description, located in the 1.18 subfolder. Here is what the current version of the pack (from the root folder) looks like: image It doesn't disappear, it just randomly appears in one of two places! And the situation randomly changes with each new launch of the game.

So, finally, steps to Reproduce:

Felix14-v2 commented 1 year ago

Also the problem isn't only visual – if you load a new version of the pack, there's a chance that it will be replaced with an old version at the next launch.

By the way, could you make the text in your mod translatable? I would like to suggest translations into my language, but at the moment I just can't do that.

enjarai commented 1 year ago

Oh I see, good catch! This shouldn't be too hard to fix, I'll definitely look into it.

Translations are a good idea, I suppose not having those is a leftover from Resource Pack Organizer. I'll let you know once I've pushed those so you can work on a PR if you want.

enjarai commented 1 year ago

Lang file support added in c366e8e, I'll work on the bugfix in a bit.

enjarai commented 1 year ago

The bug is fixed in version 2.3.0, which just released.