search

enjarai / recursive-resources

Minecraft mod that enhances the Resource Pack menu with folder support.
Mozilla Public License 2.0
20 stars 8 forks source link

No modded resourcepacks on Quilt #25

Open SplendidAlakey opened 1 year ago

SplendidAlakey commented 1 year ago

MC 1.19.2 Extended Drawers 1.3.10 Recursive Resources 2.4.2

To reproduce the crash simply install Extended Drawers and Recursive Resources, launch the game and open the resourcepacks page.

Logs: https://gist.github.com/SplendidAlakey/775559cddd7d8d06f7cd7e077f62bd49#file-crash-log https://gist.github.com/SplendidAlakey/775559cddd7d8d06f7cd7e077f62bd49#file-latest-log

To reproduce the missing modded resourcepacks on Quilt, install the same mods on Quilt and replace FAPI with QSL, then open the resourcepacks page.

2023-05-15_10 12 58

Logs: https://gist.github.com/SplendidAlakey/775559cddd7d8d06f7cd7e077f62bd49#file-latest_quilt-log

enjarai commented 1 year ago

The builtin resourcepacks from Extended Drawers apparently contain ":", which is an illegal path character, and caused a crash. I've fixed this issue and added some more robust error handling with update 2.4.3, which is publishing now, so this shouldn't happen again.

This update also includes a bit of extra logging for packs that arent being processed properly, which should help me find the issue with Quilt. Could you send another Quilt log using the new update?

SplendidAlakey commented 1 year ago

Sorry for a delayed response, here's the new Quilt logs: https://gist.github.com/SplendidAlakey/92c0a3d64d32cd54311ff40102f23031

I can also confirm, that the crash has been fixed.

enjarai commented 1 year ago 
[12:59:58] [Render thread/WARN]: [recursiveresources] Failed to determine source folder for pack: extended_drawers/alt, unknown pack type: org.quiltmc.qsl.resource.loader.impl.ModNioResourcePack
[12:59:58] [Render thread/WARN]: [recursiveresources] Failed to determine source folder for pack: extended_drawers/dev, unknown pack type: org.quiltmc.qsl.resource.loader.impl.ModNioResourcePack

There's the extra logging I added, so that works at least. It seems like Quilt has its own variant of ModNioResourcePack, which is used to represent mod-builtin packs. My mod does not know how to handle these though, since its built for Fabric.

I'll look into ways to support this, but it could get a bit complicated.

MenacingPerson commented 1 year ago

I hate to be that guy... but... this is still happening, so any fix?