search

enjarai / shared-resources

A Minecraft mod to easily share resources between multiple game instances.
https://www.curseforge.com/minecraft/mc-mods/shared-resources
GNU Lesser General Public License v3.0
31 stars 3 forks source link

World saves corrupting #39

Closed PencilVoid closed 6 months ago

PencilVoid commented 6 months ago

A weird issue I've observed on the latest version. In 1.20.2, any save that wasn't created in 1.20.2 doesn't appear in the world list, and those that do seem to be corrupted. The world icon is gone, and loading the world causes certain chunks to be deleted and regenerated, but I'd have to test this further.

Of the 3 worlds that did show in the list, one of them had this folder structure with certain folders missing: image

Game log

Additionally, resource packs are immediately reloaded again after they are initially loaded by the game launching, but that seems to be a separate issue.

MintLightning commented 6 months ago

I'm having the same issue. It erased all the data from all my worlds but somehow left the folder structure in tact. I'm really not sure what happened, but several hundred hours of work are now gone.

I guess that's what I get for not saving backups :/

PencilVoid commented 6 months ago

From further testing I've also noticed that new worlds I create disappear when I close the game.

I guess that's what I get for not saving backups :/

I would be toast right now if it weren't for Rclone. It makes copying data to another drive very convenient if you write a batch script for it.

PovarRavop commented 6 months ago

If I had not seen your issue, then all my worlds would have been deleted. Thanks for the warning!

A weird issue I've observed on the latest version. In 1.20.2, any save that wasn't created in 1.20.2 doesn't appear in the world list, and those that do seem to be corrupted. The world icon is gone, and loading the world causes certain chunks to be deleted and regenerated, but I'd have to test this further.

enjarai commented 6 months ago

I've diagnosed and fixed the issue with @MintLightning in discord. Turns out an old mixin was touching places it shouldn't in newer versions.

The problem has been fixed as of 1.8.1. Affected versions have been deleted from mod publishing websites just to be safe. I'm very sorry this happened, and hope the damage was minimal.