[Conflict] Crash with MemoryLeakFix

[JustAHuman-xD]

When starting the game with MemoryLeakFix and Shared resources i get the following crash:

Crash Error: https://pastebin.com/eeg1f0uH Crash.txt

Full Log: https://pastebin.com/WNnZs7tB latest.log

[enjarai]

Thats strange... This doesn't happen when you remove MemoryLeakFix?

[JustAHuman-xD]

Yes it does not happen when I remove memory leak fix

[enjarai]

Hmmm, I'll look into it. I can't tell from the logs where the conflict might be, but if I recreate it, I might be able to determine the cause.

[triphora]

MemoryLeakFix audits all mixins. For whatever reason, RealmsUploadScreenMixin#sharedresources$changePath fails this audit, at least on 1.19.2 (I have not tested on other versions), thus crashing the game.

[enjarai]

Oh, I would never have noticed that, do you have any idea what criteria cause the audit to fail? If not, I'll probably just disable that mixin, since its not very critical to the functioning of the mod at all.

[triphora]

You're mixing into the wrong place. The upload method almost entirely consists of creating a new thread and then all of the actual code is within that new thread. Thus, the upload method actually barely has any code, and instead the code you want is within the synthetic method_22106. I'm not entirely sure which new File call you want to target, but your mixin is going to want to target method_22106 instead of upload.

[enjarai]

Oh I see, I totally missed that lambda there and thought the errors were just intellij being funky as always. I'll push out an update to remove that mixin soon, its hard to test anyway since its to do with realms.

[enjarai]

Fixed in 1.2.1, thanks for the help!