enjarai / show-me-your-skin

A mod to hide or customize armor rendering.
https://www.curseforge.com/minecraft/mc-mods/show-me-your-skin
MIT License
24 stars 13 forks source link

Game crashes when changing settings while not in a world. #61

Closed amyfromearth closed 8 months ago

amyfromearth commented 1 year ago

Using ModMenu open settings and choose your character then clicking on elytra tab game hangs for a moment and then crashes.

crash-2023-10-05_23.10.27-client.txt

enjarai commented 8 months ago

Seems like Elytra Trims is assuming client.player to not be null when a player is rendered. My mod relies on other mods not assuming this. This has to be fixed on their side.

kikugie commented 8 months ago

Counterargument: you have Elytra Trims 1.3.3. This doesn't occur on the latest version.