enjidev / enji.dev

a monorepo for my personal website and projects, built with Turborepo + pnpm 📚
https://enji.dev
474 stars 98 forks source link

underline indicator missing needed contrast #44

Closed clay-curry closed 3 months ago

clay-curry commented 3 months ago

First of all.

WOW.

When I found your resume (on Figma Community), I was not prepared to stumble upon the cleanest personal portfolio on whole the internet. Your usage of motion, color, vector graphics, page transitions, in-page navigation, and overall monorepo architecture is a piece of art that truly speaks for itself. I can hardly believe you would be willing to share this quality of composition for free.

It took quite a lot of browsing and picking apart to find some aspect that I could possibly improve upon, and I think this suggestion boils down to a matter of personal taste. Feel free to disregard.

===

As I was initially putting together the information architecture of your site, I recall visiting your Skills & Tools page and failing to notice the underline indicator signifying your level of expertise. Though the size and positioning are appropriate, I found that the missing color contrast made it difficult to visually distinguish the indicators vs borders as well as the variability in expertise between badges. Among the available colors, I found that an alternative color scheme based on a darker shade of 'accent' captured more visual attention while keeping a sense of color consistency with the rest of the UI.

Compare the original scheme:

Screenshot_1-6-2024_201515_www enji dev

with my suggested color scheme:

Screenshot_1-6-2024_191525_localhost

Both choices have tradeoffs, so again, feel free to disregard.

Let me know what you think!

vercel[bot] commented 3 months ago

@clay-curry is attempting to deploy a commit to the Enji Kusnadi's projects Team on Vercel.

A member of the Team first needs to authorize it.

enjidev commented 3 months ago

Hi there! Your words mean a lot to me. Thank you very much, I appreciate it.

It seems like you have a good design intuition. This actually good idea!. However, since this pull request involves a visual change to my original site, I would like to request some small changes to the color shades. If you could make these changes, the PR will be ready to merge :)

clay-curry commented 3 months ago

Fixed.