search

enjin / platform

Enjin Platform is the most powerful and advanced open-source framework for building NFT platforms.
GNU Lesser General Public License v3.0
11 stars 10 forks source link

Change enjin packages versions #49

Closed leonardocustodio closed 1 month ago

leonardocustodio commented 1 month ago

PR Type

enhancement, dependencies

Description

Changes walkthrough 📝

Relevant files
Dependencies
composer.json
Update version constraints for Enjin platform packages     
configs/core/composer.json
  • Updated version constraints for enjin/platform-* packages from ^1.9 to
    ^1.0
    		•  +5/-5     

    💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    github-actions[bot] commented 1 month ago

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Version Downgrade
    The version constraints for the Enjin platform packages have been changed from '^1.9' to '^1.0'. This change represents a downgrade which might reintroduce previously fixed bugs or remove features that were added in versions after 1.0. It is crucial to ensure that this change is intentional and that all dependencies are compatible with these older versions.
    github-actions[bot] commented 1 month ago

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Specify a more precise version range for the Enjin packages to ensure compatibility ___ **Consider specifying a more precise version range for the Enjin packages to avoid
    potential compatibility issues with future major updates. Using caret (^) allows
    updates that do not modify the left-most non-zero digit in the version, which might
    introduce breaking changes unintentionally if major versions are updated.** [configs/core/composer.json [24-28]](https://github.com/enjin/platform/pull/49/files#diff-2c5e09e742287d6e5c5cae43fa69b3407e1547e04805457041dd39d0c8db1a57R24-R28) ```diff -"enjin/platform-core": "^1.0", -"enjin/platform-beam": "^1.0", -"enjin/platform-fuel-tanks": "^1.0", -"enjin/platform-marketplace": "^1.0", -"enjin/platform-ui": "^1.0", +"enjin/platform-core": "~1.0", +"enjin/platform-beam": "~1.0", +"enjin/platform-fuel-tanks": "~1.0", +"enjin/platform-marketplace": "~1.0", +"enjin/platform-ui": "~1.0", ```
    Suggestion importance[1-10]: 8 Why: The suggestion to use a more precise version range (using tilde ~ instead of caret ^) is valid as it helps avoid potential compatibility issues with future major updates. This is a best practice for maintaining stable dependencies.
    		8