search

enjine-com / mcos

Implementation of Monte Carlo Optimization Selection from the paper "A Robust Estimator of the Efficient Frontier"
MIT License
55 stars 18 forks source link

11 implement git style hooks #30

Closed biskit1 closed 4 years ago

biskit1 commented 4 years ago

Note: Did not run it on the repo yet.
Should I run it and also commit the changes to files? This is the file we have in ml-ebit. Do we want more formatting done, or is this enough? closes #11

moneygeek commented 4 years ago

No need to run the git hook on the whole repo. Let's just apply it to future commits.

Same styling guidelines as ML should be fine.

On Tue, Mar 10, 2020 at 2:24 PM Chaya Danzinger notifications@github.com wrote:

Note: Did not run it on the repo yet. Should I run it and also commit the changes to files? This is the file we have in ml-ebit. Do we want more formatting done, or is this enough?

You can view, comment on, or merge this pull request online at:

https://github.com/enjine-com/mcos/pull/30 Commit Summary

  • implemented code from link in issue
  • added tests
  • added pre-commit file
  • pre-commit config

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/enjine-com/mcos/pull/30?email_source=notifications&email_token=AAXTIXNHFNSXNSPQUQB3DJDRG2AWJA5CNFSM4LFFHN6KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IT7N7CA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXTIXIUA2RSQCDCFKPZURLRG2AWJANCNFSM4LFFHN6A .

--

Jin Choi, PhD

Founder/President

(226) 980-6902 - enjine.com

“Bring Your Quant Vision to Life”

peterwhiteenjine commented 4 years ago

Looks good to me