search

enjoy-digital / litedram

Small footprint and configurable DRAM core
Other
365 stars 115 forks source link

Add tests for litedram.frontend.adaptation #170

Closed jedrzejboczar closed 4 years ago

jedrzejboczar commented 4 years ago

Part of https://github.com/enjoy-digital/litedram/issues/156.

This adds tests for up/down converters with different conversion ratios and for CDC.

I've also added test_converter_up_not_aligned for up-converter when the pattern is not composed of groups of ratio consecutive words (example pattern), but this currently fails so I commented out that test. Do we want to support this case in LiteDRAMNativeWritePortUpConverter in the future or this test case is unnecessary?

jedrzejboczar commented 4 years ago

I've additionally changed the tests that were commented out to use @unittest.skip("...reason..."), so that they will be visible during test runs.

enjoy-digital commented 4 years ago

Thanks, this seems fine. We can merge and i'll have a closer look while validating checking that points of #156 are covered.

enjoy-digital commented 4 years ago

I'll also have a closer look a the unit-test that is commented out to see if we should need to have it.