enjoy-digital / litedram

Small footprint and configurable DRAM core
Other
365 stars 115 forks source link

_CommandChooser logic selects unwanted commands #174

Open jedrzejboczar opened 4 years ago

jedrzejboczar commented 4 years ago

This has been initially mentioned in https://github.com/enjoy-digital/litedram/pull/173.

When writing tests for core.multiplexer._CommandChooser I've noticed that the request selection defined here:

https://github.com/enjoy-digital/litedram/blob/b06e946d09807f3ab9b2e72f9c599851ab8221b4/litedram/core/multiplexer.py#L42-L47

seems to work wrong in some cases, e.g.

This behaviour can be observed in the following tests from test_command_chooser.py that fail: