frontend/fifo: increase FIFO level only after data has actually been written

enjoy-digital / litedram

Small footprint and configurable DRAM core

Other

375 stars 120 forks source link

frontend/fifo: increase FIFO level only after data has actually been written #205

Closed jedrzejboczar closed 4 years ago

jedrzejboczar commented 4 years ago

Closes https://github.com/enjoy-digital/litedram/issues/203

This removes the need for read_threshold by using port.wdata.ready (or port.w.ready for LiteDRAMAXIPort) to increment FIFO level. This way data is available for read only after it has been actually written to memory. The tests have been updated and write_threshold has also been removed as now it is not needed.

enjoy-digital commented 4 years ago

Thanks, this makes sense. Merged.