enjoy-digital / litescope

Small footprint and configurable embedded FPGA logic analyzer
Other
160 stars 38 forks source link

Allow connection settings after CSV file loading #3

Closed mithro closed 7 years ago

mithro commented 7 years ago

The analyzer CSV and CSR CSV files have useful information in it like;

It seems like it is useful to be able to load these two files first, and then initialize the actual connection to the host.

Currently you do;

    wb = RemoteClient(args.ipaddress, 1234, csr_csv="{}/csr.csv".format(make_testdir(args)))
    wb.open()

Maybe it would be better to do something like;

    wb = RemoteClient(csr_csv="{}/csr.csv".format(make_testdir(args)))
    wb.open(args.ipaddress, 1234)

That way wb.open could get the default IP address/port details from the CSR file....

enjoy-digital commented 7 years ago

This is in fact related to LiteX and not LiteScope. The csr_csv parameter was here initially to provides the register and only that. I'll think about improving this in LiteX and if it's not overcomplicating things.