search

enjoy-digital / litesdcard

Small footprint and configurable SDCard core
Other
107 stars 35 forks source link

phy: remove redundant condition checks #24

Closed gsomlo closed 3 years ago

gsomlo commented 3 years ago

@enjoy-digital -- PTAL particularly at the second hunk (removing the check for pads_out.ready): that should already be guaranteed by the If(sink.valid & pads_out.ready, check, two lines earlier -- shouldn't it?

Tested with litex+rocket on nexys4ddr, no regression AFAICT.

enjoy-digital commented 3 years ago

Thanks @gsomlo for the simplification, this was indeed redundant.