Closed bjarnef closed 7 years ago
Sweet =D What will happen if you run that view on a "old" version of Umbraco? Will it just fallback on the english translations?
No, you will probably see [theDashboard_key]
where keys are missing :)
You could check for Umbraco version and if earlier than 7.3 then merged those keys into core lang files, e.g. see how it is done in Analytics package.
I've seen how it's done there but I don't like the idea of fiddling with the core files during intall/startup. If we should merge this it need to work on all V7+ versions prior to the merge. I will not have the time to work on this in the near future so if this is something that users of the package would like to see it needs to be a joined effort to create it.
Cheers!
Yes, it isn't necessary with the upcoming 7.3 release. You could just make a changelog note that with the next package version require Umbraco 7.3+ or if earlier than 7.3 that they merge the translations keys into the core Umbraco lang files.
If you don't want to fiddle with the core files, I don't see why not to merge these changes which include the /Lang folder in the plugin folder. You can just make a note that if people are using a earlier version than Umbraco 7.3 with the next version or your package, then they should just remember to copy the keys and merge them into the core language files in their Umbraco install.
We've included the Spanish language. Could be included this pull request in the main project?
Thanks.
Issue #2
Text in content dashboard is localized for da-DK, en-GB and en-US.
The /Lang folder can be included in the plugin folder and it will work in Umbraco 7.3.0 For earlier Umbraco 7 version people has to merge those keys into the core language files.