search

enkelmedia / TheDashboard

Magic dashboard for Umbraco
MIT License
41 stars 42 forks source link

Support variant save, publish and unpublish log headers #51

Closed ronaldbarendse closed 4 years ago

ronaldbarendse commented 4 years ago

This fixes https://github.com/enkelmedia/TheDashboard/issues/48 by making sure the dashboard also shows recent activity for saving, publishing and unpublishing culture variant content.

It however doesn't show in which language this action is done, as that's only available as comma seperated language names in the umbracoLog.parameters column. That means it's not possible to add a mculture/cculture parameter to the edit links (the culture code isn't available and a single log is written if multiple languages are saved/published/unpublished in a single action). The TheDashboardController.CreateFrontendModelsFrom method also only returns a single model per node ID, so that would only return the last action and not one per language.

The NodeScheduledDate also doesn't account for the fact it can contain multiple rows per node in the umbracoContentSchedule table (one for every language). It also doesn't check whether the scheduled action is set to ContentScheduleAction.Release, so this is already the case if both a publish and unpublish date are set, but that's a different issue.

enkelmedia commented 4 years ago

Thanks for the very needed PR!

Everything looks just fine, let me give it a test run during next week and I’ll merge and create a new release.

Not sure if your comments around NodeScheduledDate is something that should be in its own issue? If you have any ideas on how to improve just create a new issue and we’ll take it from there.

I’ll let you know when I’ve looked at it :)

ronaldbarendse commented 4 years ago

Not sure if your comments around NodeScheduledDate is something that should be in its own issue? If you have any ideas on how to improve just create a new issue and we’ll take it from there.

That should indeed be it's own issue/PR and probably only needs an additional filter on the action 👍

enkelmedia commented 4 years ago

Great work on this one! Thank you very much! Great with the enum-fixes as well, I guess that it might be possible to use the nameof(Foo.Foo) in the code directly as well but I like the idea of having a list of used types in the package, it makes it clear.

Merged and released on Our and Nuget.

https://our.umbraco.com/packages/backoffice-extensions/the-dashboard/