search

enkessler / cuke_linter

A linting tool for Cucumber
MIT License
32 stars 8 forks source link

Feature/lint warn steps too long #3

Closed BillyRuffian closed 5 years ago

BillyRuffian commented 5 years ago

Simple linter warn when a step definition is too long. It is not including the gherkin keyword and I've picked 120 characters as the default max length fairly arbitrarily.

enkessler commented 5 years ago

Thanks for the contributions!

(from the README)

Create your feature branch (off of the development branch) git checkout -b my-new-feature

The dev branch is where all the fun happens, so please base your PRs off of that branch. Especially during this time when lots of linters are likely to be added in quick succession. Also, anywhere in the code where a new linter is being added to a big list, please keep the list alphabetical. There are going to be a lot of linters, so having them be in order will be convenient.

It looks like you've taken care of everything except for the lower level testing. I can add those myself but feel free to take a stab at it for future linters. Most linters are simple enough that you can just copy/paste/tweak existing tests.

BillyRuffian commented 5 years ago

Sorry, will do.