enketo / enketo-dristhi

Customized enketo-core to be used in hybrid Android app called Dristhi
Apache License 2.0
2 stars 10 forks source link

Can I remove built js and css file? #26

Closed MartijnR closed 10 years ago

MartijnR commented 10 years ago

@kirang20 can I remove enketo-dristhi-combined.min.js and dristhi.css from build folder?

I prefer not to include built files in repo. I'm sure enketo-dristhi-combined.min.js is not a problem for you, but am not sure about dristhi.css.

kirang20 commented 10 years ago

@MartijnR if these files are generated when "grunt" is run then go ahead and remove them. I will run grunt before including Enketo-Dristhi on Dristhi app. If dristhi.css is not generated when grunt is run then how do I generate this?

MartijnR commented 10 years ago

Thx. Yes both are generated with grunt. I imagine you'll probably want to copy the css build task to your own grunt file (as with the js).

On Sun, Jan 19, 2014 at 10:16 PM, Kiran G notifications@github.com wrote:

@MartijnR https://github.com/MartijnR if these files are generated when "grunt" is run then go ahead and remove them. I will run grunt before including Enketo-Dristhi on Dristhi app. If dristhi.css is not generated then how do I generate this?

— Reply to this email directly or view it on GitHubhttps://github.com/MartijnR/enketo-dristhi/issues/26#issuecomment-32734713 .

Did you know that Enketo Smart Paper has now become the #1 tool for data collection? Don't fall behind. Use it!

Enketo https://enketo.org | LinkedInhttp://www.linkedin.com/company/enketo-llc | GitHub https://github.com/MartijnR | Twitterhttps://twitter.com/enketo

kirang20 commented 10 years ago

Thanks we will include this in our build target. For integrating Enketo-Dristhi with Dristhi app this is what we had in mind:

These are the changes I can foresee now. But I may be missing some points here as I am still trying to grasp how RequireJS, Enketo-Dristhi and Ziggy are going to work together. We will have a better idea only when we try to get a form working on Dristhi app (parked till the calculations, validation, cascading logic and submission issues are fixed).

MartijnR commented 10 years ago

Sounds good. Probably best if you make the changes in martijnr/enketo-dristhi to get it the way you want it.

P.S. I don't think you need to consider the current logic issue on the Internet App on the Tab2/3 a blocker for continuing your work (only a blocker for releasing). The fix will just involve an upgrade of enketo-core. Shouldn't affect setting up your build system and integration at all.