enketo / enketo

Enketo web forms monorepo
Apache License 2.0
9 stars 15 forks source link

If a form contains a question with a comment widget, the form will load to that page #1285

Closed MartijnR closed 5 months ago

MartijnR commented 6 months ago

Describe the bug An obscure (but also cool) non-spec feature in Enketo is the comment widget. If a form contains a question with a comment widget (or strictly speaking: any question that has a for attribute in the http://enketo.org/xforms namespace on its <bind>), the form will load to that page. This is a regression introduced by https://github.com/enketo/enketo-core/pull/969, I believe.

To Reproduce Steps to reproduce the behavior.

  1. Load this form (e.g. on https://getodk.org/xlsform)
  2. Note that it opens to the second page.

Expected behavior It should open to the first page.

Additional context I was a little reluctant to report this, since I'm pretty sure this is an example of a feature you'd rather lose than fix... However, since that code is there and is currently broken I feel I have to offer a fix (which is just a one-liner).