enki-community / enki

A fast 2-D robot simulator. To contact us, please open an issue.
Other
36 stars 34 forks source link

flake8, ref #8 #62

Open nim65s opened 5 years ago

nim65s commented 5 years ago

Hi again,

This PR follows #61, after I found out that some python scripts might not work on python 3.

Then, to ensure that there is no syntax errors on those script neither in python2 nor 3, I used the flake8 linter with python2 -m flake8 and python3 -m flake8.

Most changes are:

nim65s commented 5 years ago

NB: flake8 still complains a bit about function name should be lowercase, but I did not want to change any functionality in the code

stephanemagnenat commented 5 years ago

Thank you for your PR!

Using tabs instead of whitespaces is the Enki/Aseba style. Similarly, keeping relatively long lines is as well, as most editors have good soft warp. At that point, I do not want to change this style as it has been working well for a long time, and re-indenting everything would both loose the blame history and break ongoing refactoring in the ecs-refactor branch.

Can you please submit a PR with only the necessary changes (e.g. changes in print) and no style change? Thank you!