enkidevs / curriculum

👩‍🏫 👨‍🏫 The open-source curriculum of Enki!
https://www.enki.com/mobile-app
Other
789 stars 1.13k forks source link

Update why-learn-csharp.md #3306

Closed pdimu closed 4 months ago

enki-hq commented 4 months ago

Failed parsing files:

pdimu commented 4 months ago

Failed parsing files:

  • csharp/csharp-core/intro-to-csharp/why-learn-csharp.md:

Cannot compile node with invalid type questionHeadline

please explain, @enki-hq

nem035 commented 4 months ago

Hi @okgamr, thanks for your contribution ❤️

The error you're seeing is because you changed the main heading to be an h3:

### Why It's Good to Learn C-Sharp
 ^^ you added these two #'s

This is not allowed in Enki insights as the main heading is the title of the insight, and it's required.

Regarding your other suggestions, they seem to be stylistic changes that don't necessarily improve anything about the lesson itself and are more so focused on subjective visual changes.

Can you elaborate a bit on why you're suggesting them? What is the improvement you're trying to make?

pdimu commented 4 months ago

Well, it looks more organized by that. Getting the big heading (aka title) and the points after it, but smaller so it distinguishes. If I see the one '''#''' looks well, maybe I won't just give up 😃

enki-hq commented 4 months ago

Failed parsing files:

pdimu commented 4 months ago

Now say what's wrong @enki-hq

enki-hq commented 4 months ago

Failed parsing files:

pdimu commented 4 months ago

Review again please

pdimu commented 4 months ago

Cannot compile node with invalid type thematicBreak

What is thematicBreak?

pdimu commented 4 months ago

@enki-hq

enki-hq commented 4 months ago

Insight previews:

pdimu commented 4 months ago

just that thing. JUST THAT now we got a better mental map

pdimu commented 4 months ago

@nem035 can you make the review now?

Stefan-Stojanovic commented 4 months ago

Thank you for the contribution, @okgamr 🎉

pdimu commented 4 months ago

🎉🥳