enkimute / ganja.js

:triangular_ruler: Javascript Geometric Algebra Generator for Javascript, c++, c#, rust, python. (with operator overloading and algebraic literals) -
MIT License
1.52k stars 107 forks source link

Definitions of "no" and "ni" switched in main of generated/generator code (cga.cpp, py.template.js and cga.py) #132

Open e-d-n-a opened 3 years ago

e-d-n-a commented 3 years ago

In the generated Python code for 3D-CGA or actually in the template and also in the cga.cpp the variable definitions for "no" (origin) and "ni" (point at infinity) seem to be switched and so the "up"-function shouldn't work as expected as it uses "no" and "ni" as usual (in the right way)!

The correct definitions can be seen in the Cheatsheet at ObservableHQ or at Wikipedia and should just be switched.